Skip to content

Remove readlock from managedRPCSettings

Christopher Schinnerl requested to merge host-deadlock-fix into master

Created by: VoidingWarranties

The readlock wasn't necessary as managedRPCSettings only called the exported method Settings() which has it's own readlock. The extra readlock made it possible for a deadlock to occur if a different goroutine tried to obtain a writelock after managedRPCSettings's readlock but before Settings() readlock.

fixes #1009 (closed) thanks @David60!

Merge request reports