Follow-up from "Add test for file/dir conflicts and fix managedNewSiaDir"
The following discussions from !4516 (merged) should be addressed:
-
@pjbrone started a discussion: technically you are holding two locks at the same time here
-
@pjbrone started a discussion: // will continue to have access to the dir even if another thread renames it
-
@pjbrone started a discussion: redundant
-
@pjbrone started a discussion: this should probably be
entry2
? I understand (I think) it doesn't matter but perhaps just make it entry2 to avoid confusion -
@pjbrone started a discussion: why does this rename only the second instance? What would be the result of
deleted
if you were to callentry2.Deleted()
? Does it behave like a stack? -
@pjbrone started a discussion: // will continue to have access to the dir even if another thread deletes it
-
@pjbrone started a discussion: redundant
-
@pjbrone started a discussion: (nit) multi-line to be consistent
-
@pjbrone started a discussion: // Confirm renter has no dirs in memory
Edited by Marcin S.