Follow-up from "Add skynet/portals API endpoints"
The following discussions from !4312 (merged) should be addressed:
-
@pjbrone started a discussion: (+2 comments) REQ:
v1.4.7
+ don't forget to update this version every time we release while this MR is being reviewed -
@pjbrone started a discussion: (+2 comments) PP: this method could (/should?) return an error when additions and removals conflict.
-
@pjbrone started a discussion: (+3 comments) PP: I would've defined the marshaler interface on the
PortalInfo
itself.Edit: oh I see why you haven't done that. I think I would 've preferred a persistence object alongside the user-facing
PortalInfo
object then.
All of these can be addressed at the same time by refactoring out as much of the persistence-only stuff as possible from skynetblacklist
and skynetportals
into a persist.go
file. It should be generic and not be tightly coupled with the blacklist or portals list as it is now.