Follow-up from "Add Price Gouging Protection to the Renter" - Renter's Settings from a host can be out of date
The following discussion from !4000 (merged) should be addressed:
-
@marcinja started a discussion: (+2 comments) Are you avoiding the existing
Settings
method to avoid making the extra RPC? If so it might be more clear to name thisCachedSettings
since the value can actually be stale.The host settings in the session are retrieved from the hostdb. How often does that value get refreshed? Should new sessions call the
Settings
RPC to refresh the value?
======
The core issue here is that the renter isn't actually diligent about keeping the host settings up to date while it's performing uploading and downloading.