Skip to content

ntpq: Make packet columns of collect_display2 be like collect_display.

James Browning requested to merge (removed):2022B26-ntpq into master

up to 85/6 columns wide inconsistent formatting of s/p in sysstats (via collect_display2)

123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
jamesb@taos:~/ntpsec$ build/main/ntpclients/ntpq -c sysstats ubuntu
uptime:                    1D 08:54:35
control requests:                   19
sysstats reset:               00:54:35     1D 08:54:35
packets received:                  215            7384         15.0s/p     00:00:16/p 
current version:                   204            7338         16.0s/p     00:00:16/p 
older version:                       0               3                     10:58:11/p 
bad length or format:                1              20       3275.0s/p     01:38:43/p 
authentication failed:               0               0                                
declined:                            0               0                                
restricted:                          0               3                     10:58:11/p 
rate limited:                        0               0                                
KoD responses:                       0               0                                
processed for time:                213            7360         15.0s/p     00:00:16/p 
jamesb@taos:~/ntpsec$ build/main/ntpclients/ntpq -c iostats ubuntu
time since reset:          1D 08:54:42
receive buffers:                    10
free receive buffers:                9
used receive buffers:                0
low water refills:                   1
dropped packets:                     0            
ignored packets:                     0            
received packets:                 7384     16.0s/p
packets sent:                     9078     13.0s/p
packet send failures:                0            
input wakeups:                    9268
useful input wakeups:             9268
jamesb@taos:~/ntpsec$

versus clamped at 78 columns wide and consistently formatted via both collect_display and collect_display2

12345678901234567890123456789012345678901234567890123456789012345678901234567890
jamesb@taos:~/ntpsec$ build/main/ntpclients/ntpq -c sysstats ubuntu
uptime:                  1D 08:57:47
control requests:                 22
sysstats reset:             00:57:47   1D 08:57:47
packets received:                228          7397       15.0s/p       16.0s/p
current version:                 214          7348       16.0s/p       16.0s/p
older version:                     0             3                  39556.0s/p
bad length or format:              1            20     3467.0s/p     5933.0s/p
authentication failed:             0             0                            
declined:                          0             0                            
restricted:                        0             3                  39556.0s/p
rate limited:                      0             0                            
KoD responses:                     0             0                            
processed for time:              226          7373       15.0s/p       16.0s/p
jamesb@taos:~/ntpsec$ build/main/ntpclients/ntpq -c iostats ubuntu
time since reset:        1D 08:57:52
receive buffers:                  10
free receive buffers:              9
used receive buffers:              0
low water refills:                 1
dropped packets:                   0              
ignored packets:                   0              
received packets:               7398       16.0s/p
packets sent:                   9095       13.0s/p
packet send failures:              0              
input wakeups:                  9285
useful input wakeups:           9285
jamesb@taos:~/ntpsec$

Merge request reports