decodenetnum tests fail on Ubuntu 16.04 docker image
The Ubuntu 16.04 LTS docker image does not contain an /etc/services file.
The following tests fail:
TEST(decodenetnum, Services)../../tests/libntp/decodenetnum.c:27::FAIL: Expected Not-Equal
In 25a240c2, we added the test for /etc/services. Why do we open this explicitly instead of checking for a working getservbyname() implementation?
TEST(decodenetnum, IPv4AddressOnly)../../tests/libntp/decodenetnum.c:44::FAIL: Expected 0 Was -8
TEST(decodenetnum, IPv4AddressWithPort2)../../tests/libntp/decodenetnum.c:76::FAIL: Expected 0 Was -8
TEST(decodenetnum, IPv6AddressOnly)../../tests/libntp/decodenetnum.c:98::FAIL: Expected 0 Was -8
These tests fail because service resolution fails. I can fix the docker image by installing the netbase package, but we should fail our tests in a better way.
Maybe stop completely when the first test fails? Also, a better test failure message on the first test would have saved me a bunch of time investigating.