32 bit OS warnings

On 32 bit OS some pointers have bad alignment:

From Raspberry Pi and BeagleBone Black:
../../ntpd/ntp_control.c: In function ‘ctl_error’:
../../ntpd/ntp_control.c:714:35: warning: cast increases required alignment of target type [-Wcast-align]
   maclen = authencrypt(res_keyid, (uint32_t *)&rpkt,
                                    ^
../../ntpd/ntp_control.c: In function ‘process_control’:
../../ntpd/ntp_control.c:830:35: warning: cast increases required alignment of target type [-Wcast-align]
   else if (authdecrypt(res_keyid, (uint32_t *)pkt,
                                   ^

I think this alert is a little bit to early, isn't it ?

May 22 21:37:39 ntpd[3483]: This system has a 32-bit time_t.
May 22 21:37:39 ntpd[3483]: This ntpd will fail on 2038-01-19T03:14:07Z.

But some funny messages in the syslog are always welcome.

// Hans

Gotta start sometime. We figure some IoT will still be around in 20 years. 10 years is clearly too short a time. I have many 10 year old boxes on the internet. Maybe 15 years is the right number, but why wait?

I have many 10 year old boxes on the internet.

How many of them don't have a way to update the firmware?

I guess there are 2 possible reasons. The first is the device doesn't have any way to update the firmware. The second is that the manufacturer doesn't provide new firmware. (Maybe because they went out of business.)

Yo Hal!

I have many 10 year old boxes on the internet.

How many of them don't have a way to update the firmware?

Most of them have a way, there is just no newer firmaware to update to.

Or, I have some very paranoid clients that resufuse to ever update a UNIX box. Some of those are now well past 10 years too.

I guess there are 2 possible reasons. The first is the device doesn't have any way to update the firmware. The second is that the manufacturer doesn't provide new firmware. (Maybe because they went out of business.)

Or because they do not care. I have a lot of name brand stuff that only got updates the first year, if ever.

RGDS GARY

This is a deep bug related to Deniel Franke's issue about not relying on self-alignment to make packets treatable as sequences of 32-bit ints. He needs to finish the changes to packet representation in the protocol machine; the fix should fall out of that pretty automatically.

@dfoxfranke I'm going to assign this bug to you. Can you schedule time to work on this in the near future?

assigned to @dfoxfranke

mentioned in commit 042c96d4

assigned to @esr

I misdiagnosed the problem. Fix pushed. Bug reassigned to me in case it needs to be reopened.

closed

mentioned in merge request !1436 (merged)