Skip to content

GitLab

RediStack
RediStack
Closed
Opened by Nathan Harris@MordilMaintainer6 of 8 tasks completed6/8 tasks

SSWG Review Feedback

During the feedback thread for reviewing the SSWG-0004 RedisNIO proposal, several action items were identified to make RedisNIO the best it can be for 1.0.0.

  • Change RedisCommandHandler from open to public final
  • Move & Rename Redis.makeConnection to RedisConnection.connect
  • Move & Rename Redis.makeDefaultClientBootstrap to ClientBootstrap.makeRedisTCPClient
  • Remove Redis namespace enum
  • Add label to RESPValueConvertible.init requirement
  • Change RESPTranslator logic to copy the ByteBuffer and move the reader index instead of a mutable position value.
  • Clarify language in RESPClient.expire to be consistent with timeouts instead of deadlines
  • Rename RedisCommandContext to RedisCommand
    • This should include documentation to warn users of reference semantics from the EventLoopPromise
Edited by Nathan Harris
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information