Skip to content

Bug fix to isConnected in GuestRegistrySource.java.

Christopher Chase requested to merge !395_handling_no_connection into main

License and Copyright Notice

By submitting this issue or commenting on this issue, or contributing any content to this issue, you certify under the Developer Certificate of Origin that the content you post may be licensed under GPLv3 (for code) or CC-BY-SA 4.0 International (for non-code content).

Branch Name

!395 (merged)_handling_no_connection

Related Issues

What to do if the app isn't seeing the database.

Description

This merge request contains some bug fixes as well as a temporary bandaid solution that doesn't allow the user to go any further if they are not connected to the database. I have also changed some label names so that it is easier to keep track of things A tiny thing I have placed as well is a link under future efforts, that allows the user to go straight to the website that allows them to submit their IP when they are on campus.

Steps to Test

Going through Guest Visit Checkin should lead you to what was being done. If you're connected to the database, a correct label is shown and you are carried to the next screen. If you're not connected, a toast is displayed.

If you go through future efforts, if you scroll down you can see the link to the website.

You can also see the label changes throughout: app/src/main/res/layout/activity_future_efforts.xml app/src/main/res/layout/fragment_guest_visit_confirmation_found.xml app/src/main/res/values-b+es/strings.xml app/src/main/res/values/strings.xml

Relevant Screenshots

Screenshot_2023-08-23_at_9.47.40_AM

Screenshot_2023-08-23_at_9.47.26_AM

Developer Notes

This merge request aims to improve the code of the master branch instead of providing a solution to what to do when not connected to the database. That being said, not letting the user continue forward is a quick bandaid fix while a real solution is created.

Merge request reports