Skip to content

WIP: Updating the way shelf life is displayed

A H requested to merge issue_228_update_shelf_life_display into main

License and Copyright Notice

By submitting this issue or commenting on this issue, or contributing any content to this issue, you certify under the Developer Certificate of Origin that the content you post may be licensed under GPLv3 (for code) or CC-BY-SA 4.0 International (for non-code content).

Branch Name

issue_228_update_shelf_life_display

Related Issues

Closes #228 (closed)

Dependencies

Merge Request #230 (closed)

Description

Because of a lot of recent changes to the UI and subsequent changes to how shelf life is calculated, as well as decisions surrounding what should be considered the shelf life, there needs to be an updating of DisplayTrueExpirationFragment to utilize some of the changes that were made.

Steps to Test

I like to clear all data associated with the app by uninstalling the app from the device I am testing it on and reinstalling it via Android Studio.

Scan the item.

You will be taken to SelectItemFragment:

Select a "Category", "Product", and "Type" (if required)
Hit "Accept"

You will be taken to SelectPrintedExpirationDateFragment:

Input the expiration date
Hit "Accept"

You will be taken to StatusFragment:

Hit "More Info"

Check under 'Shelf Life Information' that the 'Shelf Life' is properly displaying, with an appropriate 'Days','Months', or 'Years' label.

Relevant logs and/or screenshots

An example of how it should look:

Developer Notes

  • Utilized data passed over from StatusFragment in DisplayTrueExpirationFragment
  • Deleted unused methods in DisplayTrueExpirationFragment
  • Ensured a proper label (days, months) was displayed alongside the Shelf Life

LABELS

`Type::Refactor'

Edited by A H

Merge request reports