Skip to content

Removing brand and description from SelectItemFragment

Tyler Sizse requested to merge issue_229_remove_brand_and_description into main

License and Copyright Notice

By submitting this issue or commenting on this issue, or contributing any content to this issue, you certify under the Developer Certificate of Origin that the content you post may be licensed under GPLv3 (for code) or CC-BY-SA 4.0 International (for non-code content).

Branch Name

issue_229_remove_brand_and_description

Related Issues

Closes #229 (closed); May need to update the issue or create a new one about updating the database structure.

Dependencies

None

Description

This merge request will completely remove brand and description entries from SelectItemFragment and will instead use a placeholder String value of "not specified" for the brand and description when storing a new UPC in the database.

Steps to Test

NOTE: Make sure to wipe database before testing this, or to use a barcode that is not already in the database.

  1. Go to the 'Check Expiration Date' feature within the app.
  2. Scan or enter a barcode.
  3. Select the required information if in SelectItemFragment randomly, or press Confirm Item if in ConfirmItemFragment.
  4. Press Accept
  5. Select a random date.
  6. Press Accept
  7. Make sure navigation was successful and that you no longer see brand or description in any of the fragments.

Repeat steps 1-6 using the same barcode.

Relevant Screenshots

Screenshot__150_ Screenshot_1627238871

Relevant Logs

N/A

Developer Notes

  • Wasn't sure how to split this into multiple issues since it is straight forward and requires minimal changes.
  • Removed EditText and TextView objects relating to brand and description from the layout.
  • Removed code relating to brand and description from SelectItemFragment

LABELS

NEST component:check-expiration-date type::other status::doing

Edited by Tyler Sizse

Merge request reports