Skip to content

resolve many lint issues; update lint rules

Tristan Kernan requested to merge github/fork/tristanmkernan/refactor/lint into master

this is the first PR to attempt to resolve all of the lint issues so that the project will always pass the linter. there are some outstanding questions/thoughts:

  • console.log, alert, and confirm should not be used but they are used
  • jsdoc would have been more useful as code was written, it's hard to go back and write the documentation after the fact
  • socket.js does not do anything? can always be restored from git history / rewritten
  • there was a bug in endGame() that i resolved
  • lint should be run with travis to ensure code quality is always maintained
  • there will be more PRs to clean up the remaining lint issues / add travis

Merge request reports