You need to sign in or sign up before continuing.
Improvement: Clean up Peter
This MR aims to vastly clean up overall code quality of Peter by
- Separating concerns where appropriate
- Big one here is separating the logic behind test logs and test runs
- Updating the docs (both README, -h page, and various JS docs)
- Reducing # functions by removing redundant methods and creating shared methods across drivers
- This also ties to the separation of concerns between test logging and running
- Ex. Test timeout logic was scattered across each driver, this has been converted to a shared function that all drivers can use
- Re-implementing
--version/-V
option - Decreasing # of variables and combining into objects where appropriate
- Removing various redundant checks scattered throughout the codebase
- Ex. Removing multiple similar checks like
knownFailingTest = testFile.endsWith('.failing');
- Instead, check and set this once, and then re-use the same variables. Don't keep doing the same checks over and over
- Ex. Removing multiple similar checks like
- Increased readability in some areas
Edited by Elijah Deluzio