Skip to content

Fixed issue with doors

Coral Golem requested to merge fixbadboolpacket into master
  • There were two errors in the door class. One, we were sending PublicUpdatePropertyBool 02D2 messages without a sender guid.
  • That is just a malformed packet - see http://ac.zegeger.net/protocol/ You can send a PrivateUpdatePropertyBool 02D1 without a target, but not the public one. Next, even though it is passing a bool value, it is sent as a uint. If you do not send 4 bytes, both viewers cannot read the stream. I thought it might be a boundry align issue, but adding align did not fix the issue.
  • Finally and this is a big one - I can find no PCAP where we are opening doors were we are sending this update at all. It does not seem to hurt anything to send the extra information - we are sending is open and is ethereal but if you comment them out, we still pass through the door - I have been unable to find a on use in live pcaps of a door where we send public or private bool updates for those two properties.

Merge request reports