Skip to content

Use Poetry for build process

Derrick Liu requested to merge python-and-poetry into dev

@DSASanFrancisco/portal-members

This PR switches the Docker build process from requirements.txt to Poetry's pyproject.toml and poetry.lock to deterministically install dependencies.

To support Poetry's build, I switched the Docker image from using alpine:3.6 to python:3.7-alpine. This update required some dependency updates and minor tweaks to fix tests. As a bonus, the Docker image should be ~100MB smaller now.

I have:

  • Included a summary of the changes
  • Linked all relevant Trello tickets to this request
  • Linked all relevant GitLab issues to this request (optional -- prefer Trello, but GitLab is easier for fast-follow cleanup issues)
  • Listed all dependent merge requests in this summary (optional)

Merge Request Rules

Author

  • If the MR isn't finished, prepend "WIP" to the title.
  • Unless otherwise noted, you should merge after approval.

Reviewer

  • Comments aren't necessarily blockers but can be. Add [blocker], or something similar, to a comment as necessary, otherwise the author may not know what's a blocker and what's not.
  • Bias toward approving the MR and ask for follow-up work as needed. You can make these issues as needed.
  • Be proactive about approving. If you and other reviewers make comments, and yours are resolved by the author, use your judgement to either approve or follow up with the other reviewers. Again, bias toward approving.

Merge request reports