Skip to content

Member interests route

Derrick Liu requested to merge svdsa/membership_api:member-interests-route into dev

@DSASanFrancisco/portal-members

This PR adds a /member/interests route to supplement the existing /email_topics/add_member route. The UI can GET the current logged in member's interests from the route, or can PATCH an updated list of member interests to the route.

To support this, this PR also adds an optional flag to the interest_topics_service.create_interests method to disable implicit creation of new interest topics. I also wrote two new methods, .create_interest_topics and .delete_interest_topics to provide for explicit modification of this table. These new methods are not used yet, but a following PR could add topic management as an admin-only API route.

I have:

  • Included a summary of the changes
  • Linked all relevant Trello tickets to this request
  • Linked all relevant GitLab issues to this request (optional -- prefer Trello, but GitLab is easier for fast-follow cleanup issues)
  • Listed all dependent merge requests in this summary (optional)

Merge Request Rules

Author

  • If the MR isn't finished, prepend "WIP" to the title.
  • Unless otherwise noted, you should merge after approval.

Reviewer

  • Comments aren't necessarily blockers but can be. Add [blocker], or something similar, to a comment as necessary, otherwise the author may not know what's a blocker and what's not.
  • Bias toward approving the MR and ask for follow-up work as needed. You can make these issues as needed.
  • Be proactive about approving. If you and other reviewers make comments, and yours are resolved by the author, use your judgement to either approve or follow up with the other reviewers. Again, bias toward approving.
Edited by Derrick Liu

Merge request reports