Skip to content

Fixes welcome emails not being able to send.

Chris Thoma requested to merge email-fix into dev

@DSASanFrancisco/portal-members

SUMMARY

The wrong recipients object was being used to create the list of who to send it to.

Reviewer

  • Comments aren't necessarily blockers but can be. Add [blocker], or something similar, to a comment as necessary, otherwise the author may not know what's a blocker and what's not.
  • Bias toward approving the MR and ask for follow-up work as needed. You can make these issues as needed.
  • Be proactive about approving. If you and other reviewers make comments, and yours are resolved by the author, use your judgement to either approve or follow up with the other reviewers. Again, bias toward approving.

Merge request reports