Skip to content

Use roles for eligibility details

Drew requested to merge search-display into dev

@DSASanFrancisco/portal-members

Right now we're only checking for members who have attended 2 out of the past 3 meetings, but now we have information about active members!

Not sure what the impact on runtime will be. There's an additional query to pull the roles for each user, but we were also querying for each individual meeting on the attendees, so I think we may actually be lowering the number of queries made.

Next step on this will be fixing MeetingRepo to pull the previous 3 general meetings, excluding intro meetings, meetings that haven't happened/finished, and committee meetings.

Merge Request Rules

Author

  • If the MR isn't finished, prepend "WIP" to the title.
  • Unless otherwise noted, you should merge after approval.

Reviewer

  • Comments aren't necessarily blockers but can be. Add [blocker], or something similar, to a comment as necessary, otherwise the author may not know what's a blocker and what's not.
  • Bias toward approving the MR and ask for follow-up work as needed. You can make these issues as needed.
  • Be proactive about approving. If you and other reviewers make comments, and yours are resolved by the author, use your judgement to either approve or follow up with the other reviewers. Again, bias toward approving.

Merge request reports