Skip to content

Return an 'email' object in the JSON for an email rule on save and update

David Fritsch (dfritsch) requested to merge return-email-rule-on-save into dev

@DSASanFrancisco/portal-members

This goes with membership_ui!118 (merged). The API was returning just {'status': 'success'} on create, meaning that we didn't know what the ID for the new record is.

This always returns the whole email record on save, so we don't have to fetch the list again.

I have:

  • Included a summary of the changes
  • Linked all relevant Trello tickets to this request
  • Linked all relevant GitLab issues to this request (optional -- prefer Trello, but GitLab is easier for fast-follow cleanup issues)
  • Listed all dependent merge requests in this summary (optional)

Merge Request Rules

Author

  • If the MR isn't finished, prepend "WIP" to the title.
  • Unless otherwise noted, you should merge after approval.

Reviewer

  • Comments aren't necessarily blockers but can be. Add [blocker], or something similar, to a comment as necessary, otherwise the author may not know what's a blocker and what's not.
  • Bias toward approving the MR and ask for follow-up work as needed. You can make these issues as needed.
  • Be proactive about approving. If you and other reviewers make comments, and yours are resolved by the author, use your judgement to either approve or follow up with the other reviewers. Again, bias toward approving.

Merge request reports