Skip to content

Fixed importing from URI starting with http

Passes extra values to the importKeyFromValue function to enable the importing from URI starting with "http" to work.

Fixes #1150 (closed) .

Marked as Draft because I've based it on code from my previous merge request (!542 (merged)), but I'm not sure if I'm supposed to do that or not. If I should change something about that, please let me know.

I'd also like some feedback on the way the values are passed through when the user presses the button in the Public Keys tab on the right (in the viewer). In that case, the only values that are passed are the attributes from the card that are actually being used. I have done it in this way because they get saved as attributes to the button when the button is created, and are then loaded from there when it is clicked. While it does work, I don't think it's a particularly neat solution. For easy reference, the values are passed through as follows:

  1. displayCard - cardbookWindowUtils.js#864
  2. constructStaticKeysRows - cardbookWindowUtils.js#1305
  3. loadStaticKeysTypes - cardbookWindowUtils.js#2148
  4. addKeyButton - cardbookElementTools.js#702
  5. addKeyButton:fireKeyCheckBox - cardbookElementTools.js#711
  6. importKeyFromValue - wdw_cardbook.js#1272

The reason for passing it as values is the step from 4 to 5.

Edited by CardBook

Merge request reports