We want to check if some file is already cached here, not the parent
directory.

Tristan Maat created the original file, so he is added as the author.

* Rename it to _commit_directory() because… it is what it does; and
  also for symmetry with _fetch_directory().
* Rename digest to dir_digest to make it clear this is a digest for a
  directory. A following commit will also reuse the same variable name
* Document method.

* Rename tree to dir_digest to make it clear this is a Digest object,
  and not a Tree object.
* Add documentation

Remove unneeded cruft.

Bunch of cleanups

See merge request !798

Somehow I missed this when originally forking the file from the click
library, now noticing that we should have followed what was written
in: https://github.com/pallets/click/blob/master/LICENSE

richardmaw-codethink authored Sep 10, 2018 and Tristan Van Berkom committed Sep 16, 2018

Since we now set PWD in the environment of builds
existing builds may behave differently so must cache differently now.

richardmaw-codethink authored Sep 11, 2018 and Tristan Van Berkom committed Sep 16, 2018

The current directory isn't always in the python module search path,
so we have to ensure it is for the script to work.

Strictly speaking, the user may already have a modified PYTHONPATH
at which point PYTHONPATH=".${PYTHONPATH+:$PYTHONPATH}" is necessary,
but it's probably premature to overcomplicate the documentation like that
before we discover it's a problem.

Address post-merge review of Ensure PWD is set in process environment

See merge request !788

Update contributing guide

See merge request !801

This ensures that option expressions are resolved in the project
level overrides before attempting to composite them on the instantiated
elements. Seems this is a regression from introducing the include
directive.

This fixes issue #658

This is a regression test for issue #658

Fix override options

Closes #658

See merge request !802

Since ArtifactCache.setup_remotes() can be expensive and should only
happen once, this commit will assert() if it is called a second time
on an artifact cache instance.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

The initialization of remotes is done by ArtifactCache.setup_remotes()
and as such it was wrong for these tests to be calling
CASCache.initialize_remotes() a second time.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

The SandboxRemote used to construct its own CASCache which was
considered dangerous.  This patch replaces that with acquisition of
the cache via the Platform singleton, hopefully eliminating issues
from having more than one artifact cache object in a single process.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

sandbox/_sandboxremote.py: Acquire cache via Platform

See merge request !797

When configuring a push remote and specifying either the client-cert
or the client-key, then both must be specified. This ensures we
get an informative error instead of a stack trace and BUG.

Fixes issue #625

Test that we get the expected error when configuring a client-cert
without client-key, or the inverse.

Fix artifact config crash

Closes #625

See merge request !804

richardmaw-codethink authored Sep 04, 2018 and Tristan Van Berkom committed Sep 18, 2018

This fixes all devices being mapped to the non-existant device 0,
which prevents being able to use even safe devices like /dev/null
through the hardlinks FUSE layer.

richardmaw-codethink authored Sep 04, 2018 and Tristan Van Berkom committed Sep 18, 2018

This is needed to permit access to the device nodes added to /dev
on Linux when FUSE is used as root.

The chroot sandbox only works with all privileges,
so there's no explicit check for being root
or having the appropriate capabilities.

A check for whether it's running as root isn't needed on Linux with bubblewrap
because /dev or its devices are mounted on top of the FUSE layer,
so device nodes are accessed directly rather than through the FUSE layer.

fix chroot sandbox devices

See merge request !781

bst build returns "missing project.conf" when a project.conf is invalid
This results in an existing project with malformed yaml being dismissed
and attempts to make a new project

Added new exception

Incorrect error when malformed project.conf

Closes #642

See merge request !792