* Enhanced the base Job class to bookkeep which jobs have
   been terminated, and to consider them as `skipped` when
   asked via the `skipped` property.

 * Enhanced the base Queue class to bookkeep the job statuses
   more carefully.

This fixes #479

_scheduler: Fix bookkeeping of terminated jobs

Closes #479

See merge request !850

tests: Add regression test for mirroring with project.refs

See merge request !823

Tristan Van Berkom authored Oct 03, 2018 and Tristan Van Berkom committed Oct 03, 2018

For some reason, we now receive a SIGINT from the main loop even
when the SIGINT occurred with the handler disconnected in an interactive
prompt. This patch simply ignores any received SIGINT events from the
main loop in the case that we are already in the process of terminating.

This fixes issue #693

_scheduler/scheduler.py: Ignore interrupt events while terminating.

Closes #693

See merge request !852

Tristan Van Berkom authored Oct 03, 2018 and Tristan Van Berkom committed Oct 03, 2018

Allow callers to decide where the temporary file will be created.

Tristan Van Berkom authored Oct 03, 2018 and Tristan Van Berkom committed Oct 03, 2018

Use the designated tempdir when creating refs, we expect that temporary
files are not created in the storage directory ever, they should be
only ever created in the designated temporary directory.

This fixes race conditions where utils._get_dir_size() throws an
unhandled exception when attempting to stat the file which inadvertantly
disappears.

Tristan Van Berkom authored Oct 03, 2018 and Tristan Van Berkom committed Oct 03, 2018

This function assumes that files do not disappear while
walking the given directory.

fix cache size race

See merge request !854

Move the temporary staging directory to artifactdir

See merge request !856

Since the SandboxDummy sandbox is only used in very specific
circumstances and with good reason, this adjusts the SandboxDummy
class to take a reason and to return it if `.run()` has to
raise an exception because this is a dummy sandbox.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

Since Darwin is limited to the dummy sandbox for now due to OSXFUSE
being unsupported as yet, and there being no suitable sandboxing option
for use on OSX, give this as the reason so that it can be reported if
the user attempts a local build.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

To better report issues in the absence of a suitable bwrap, or the
FUSE devices, this refactors the checks for sandboxing in the Linux
platform to cover the various possibilities.  The reasons are then
collated and passed to the dummy sandbox for later reporting to the
user if a local build is attempted.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

On some potentially broken systems, running `bwrap --version` might
fail with an error code.  This patch corrects the oversight ensuring
that we cleanly return False for version checking in such cases.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

Instead of an if/else ladder which is quite complex, this patch
uses the fact that Python supports by-component tuple comparison
to simply compare two (major, minor, patch) tuples

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

Since there are use-cases where BuildStream could be installed
onto systems which do not have BubbleWrap (e.g. for remote-build-only
scenarios) it is not correct to assert a dependency on bwrap during
installation.  This patch makes the assertion a warning, and also
clarifies the message somewhat.  This should fix #644

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

Make bwrap check runtime only

Closes #644

See merge request !847

Qinusty authored Sep 19, 2018 and Tristan Van Berkom committed Oct 04, 2018

This fixes #634, BuildStream no longer saves workspace configuration on
a failed build.

Do not save workspace on failed build

Closes #634

See merge request !812

Valentin David authored Oct 02, 2018 and Valentin David committed Oct 04, 2018

Python documentation is not clear on what shutil.rmtree is supposed to
raise. However from the source code, it is obvious that OSError are
raised, but never shutil.Error.

It is not easy to test in normal condition because issues happen
usually in combination with a FUSE filesystem, a probably a race
condition where `fstatat` returns an error just before the filesystem
being unmounted.

Fixes #153.

Catch correct exception from shutil.rmtree

Closes #153

See merge request !849

Chandan Singh authored Oct 03, 2018 and Jonathan Maw committed Oct 05, 2018

This script can be useful to generate a Docker image from `bst checkout`
of an element as a single command. While this script does not eliminate
the need for a proper Docker/OCI element plugin that would probably also
support layering, it provides a cheap way to export the element into a
Docker image.

Add contrib script to generate Docker images from bst checkout

See merge request !857

Jürg Billeter authored Oct 04, 2018 and Jonathan Maw committed Oct 05, 2018

A remote execution sandbox is not suitable for these commands.

element.py: Prepare local sandbox for bst checkout and bst shell

See merge request !860

This is almost a complete rewrite of the CONTRIBUTING guide.

  * The patch submission guidelines have become less ambiguous and more strict

  * Some general restructuring and reordering of the file took place

  * The codeing guidelines have changed completely.

    o There is much less room for ambiguity here now
    o More emphasis on consistency in the codebase
    o Added some more abstract points which should be considered
      when writing and reviewing patches

  * The policy on public/private symbols has been greatly clarified

  * Added new section about adding new core plugins and what needs
    to be done as a consequence of that

contributing.rst: fix typos

See merge request !865

And modified some titles so that the titles in CONTRIBUTING.rst actually
follow the documentation guidelines for naming of section titles.

This example is very outdated and comes from pre 1.0 when the Context
object was going to be public API. Just corrected the example made about
imports to import the `Context` object from `._context` instead of `.context`.

We have a long line limit in order to handle the exceptions without making
code unreadable as a result, this long line length limit is not an invitation
to fill up the limit as much as possible.

The code was creating the cwd folder but when the workspace was
mounted in to the buildroot it was hiding the folder created in it
behind the bind mounted workspace.

However by using the bubblewarp `--dir` directive to ensure that cwd
exists we can cover both workspace and non workspace situations with
the same method.

Build stream was only creating command-subdir for non workspace builds
this has now been fixed, and this regression test should support the
feature.

Adding the conf-root variable makes creating out of source builds
slightly easier.

Three examples covering out of source builds for:
 * basic autotools
 * basic cmake
 * autotools from a folder inside the source folder

This is also the first cmake example.