Skip to content
Snippets Groups Projects

Compare revisions

Changes are shown as if the source revision was being merged into the target revision. Learn more about comparing revisions.

Source

Select target project
No results found

Target

Select target project
  • willsalmon/buildstream
  • CumHoleZH/buildstream
  • tchaik/buildstream
  • DCotyPortfolio/buildstream
  • jesusoctavioas/buildstream
  • patrickmmartin/buildstream
  • franred/buildstream
  • tintou/buildstream
  • alatiera/buildstream
  • martinblanchard/buildstream
  • neverdie22042524/buildstream
  • Mattlk13/buildstream
  • PServers/buildstream
  • phamnghia610909/buildstream
  • chiaratolentino/buildstream
  • eysz7-x-x/buildstream
  • kerrick1/buildstream
  • matthew-yates/buildstream
  • twofeathers/buildstream
  • mhadjimichael/buildstream
  • pointswaves/buildstream
  • Mr.JackWilson/buildstream
  • Tw3akG33k/buildstream
  • AlexFazakas/buildstream
  • eruidfkiy/buildstream
  • clamotion2/buildstream
  • nanonyme/buildstream
  • wickyjaaa/buildstream
  • nmanchev/buildstream
  • bojorquez.ja/buildstream
  • mostynb/buildstream
  • highpit74/buildstream
  • Demo112/buildstream
  • ba2014sheer/buildstream
  • tonimadrino/buildstream
  • usuario2o/buildstream
  • Angelika123456/buildstream
  • neo355/buildstream
  • corentin-ferlay/buildstream
  • coldtom/buildstream
  • wifitvbox81/buildstream
  • 358253885/buildstream
  • seanborg/buildstream
  • SotK/buildstream
  • DouglasWinship/buildstream
  • karansthr97/buildstream
  • louib/buildstream
  • bwh-ct/buildstream
  • robjh/buildstream
  • we88c0de/buildstream
  • zhengxian5555/buildstream
51 results
Show changes
Commits on Source (2)
  • Sam Thursfield's avatar
    Don't strip pathname from debug symbol files · 0bcfdfb9
    Sam Thursfield authored and Tristan Van Berkom's avatar Tristan Van Berkom committed 
    When GDB looks for debug symbols it looks for the full path of the file
inside the configured debug-file-directory. For example, if the
debug-file-directory is set to a default of /usr/lib/debug, and you are
debugging /usr/bin/python3, GDB will look for its debug symbols at this
location: /usr/lib/debug/usr/bin/python3.

BuildStream has been putting all debug files inside /usr/lib/debug
under their $(basename), so in the above example GDB would fail to find
any debug symbols for /usr/bin/python3 because they would be in the
incorrect locatoin of /usr/lib/debug/python3.
    0bcfdfb9
  • Tristan Van Berkom's avatar
    Merge branch 'tristan/debug-symbols-location-1.2' into 'bst-1.2' · b567666d
    Tristan Van Berkom authored 
    Don't strip pathname from debug symbol files

See merge request !698
    b567666d
Hide whitespace changes
Inline Side-by-side
Showing
with 29 additions and 15 deletions
buildstream/data/projectconfig.yaml
View file @ b567666d
...@@ -72,7 +72,7 @@ variables: ...@@ -72,7 +72,7 @@ variables:
# Generic implementation for stripping debugging symbols # Generic implementation for stripping debugging symbols
strip-binaries: | strip-binaries: |
find "%{install-root}" -type f \ cd "%{install-root}" && find -type f \
'(' -perm -111 -o -name '*.so*' \ '(' -perm -111 -o -name '*.so*' \
-o -name '*.cmxs' -o -name '*.node' ')' \ -o -name '*.cmxs' -o -name '*.node' ')' \
-exec sh -ec \ -exec sh -ec \
...@@ -80,7 +80,7 @@ variables: ...@@ -80,7 +80,7 @@ variables:
if [ "$hdr" != "$(printf \\x7fELF)" ]; then if [ "$hdr" != "$(printf \\x7fELF)" ]; then
exit 0 exit 0
fi fi
debugfile="%{install-root}%{debugdir}/$(basename "$1")" debugfile="%{install-root}%{debugdir}/$1"
mkdir -p "$(dirname "$debugfile")" mkdir -p "$(dirname "$debugfile")"
objcopy %{objcopy-extract-args} "$1" "$debugfile" objcopy %{objcopy-extract-args} "$1" "$debugfile"
chmod 644 "$debugfile" chmod 644 "$debugfile"
......
tests/cachekey/project/elements/build1.expected
View file @ b567666d
e7de3dd12a1e5307e07859ddf2192443a0ccb1ff48e0adcc6c18f9edc2bd0d7d afab4c1a67d1e06489083fa1559bda0b2c8df9b7bc239820ed7cdab30c988a4e
\ No newline at end of file \ No newline at end of file
tests/cachekey/project/elements/build2.expected
View file @ b567666d
d74957e0f20a7664e9ceed6cc2ba6c140bd8d8d0712d02066feb442638e8e6ed 47395a4e6c86372b181ad1fd6443e11b1ab54c480b7be5e5fe816d84eec3b369
\ No newline at end of file \ No newline at end of file
tests/cachekey/project/target.expected
View file @ b567666d
01f611e61e948f32035b659d33cdae662d863c99051d0e6746f9c5626138655f 46f48e5c0ff52370ff0cf2bb23bd2c79da23141e6c17b9aa720f7d97b7194340
\ No newline at end of file \ No newline at end of file
tests/examples/autotools.py
View file @ b567666d
...@@ -28,7 +28,9 @@ def test_autotools_build(cli, tmpdir, datafiles): ...@@ -28,7 +28,9 @@ def test_autotools_build(cli, tmpdir, datafiles):
assert_contains(checkout, ['/usr', '/usr/lib', '/usr/bin', assert_contains(checkout, ['/usr', '/usr/lib', '/usr/bin',
'/usr/share', '/usr/lib/debug', '/usr/share', '/usr/lib/debug',
'/usr/lib/debug/hello', '/usr/bin/hello', '/usr/lib/debug/usr', '/usr/lib/debug/usr/bin',
'/usr/lib/debug/usr/bin/hello',
'/usr/bin/hello',
'/usr/share/doc', '/usr/share/doc/amhello', '/usr/share/doc', '/usr/share/doc/amhello',
'/usr/share/doc/amhello/README']) '/usr/share/doc/amhello/README'])
......
tests/examples/flatpak-autotools.py
View file @ b567666d
...@@ -47,8 +47,10 @@ def test_autotools_build(cli, tmpdir, datafiles): ...@@ -47,8 +47,10 @@ def test_autotools_build(cli, tmpdir, datafiles):
assert_contains(checkout, ['/usr', '/usr/lib', '/usr/bin', assert_contains(checkout, ['/usr', '/usr/lib', '/usr/bin',
'/usr/share', '/usr/lib/debug', '/usr/share', '/usr/lib/debug',
'/usr/lib/debug/hello', '/usr/bin/hello', '/usr/lib/debug/usr', '/usr/lib/debug/usr/bin',
'/usr/share/doc', '/usr/share/doc/amhello', '/usr/lib/debug/usr/bin/hello',
'/usr/bin/hello', '/usr/share/doc',
'/usr/share/doc/amhello',
'/usr/share/doc/amhello/README']) '/usr/share/doc/amhello/README'])
......
tests/integration/autotools.py
View file @ b567666d
...@@ -31,8 +31,10 @@ def test_autotools_build(cli, tmpdir, datafiles): ...@@ -31,8 +31,10 @@ def test_autotools_build(cli, tmpdir, datafiles):
assert_contains(checkout, ['/usr', '/usr/lib', '/usr/bin', assert_contains(checkout, ['/usr', '/usr/lib', '/usr/bin',
'/usr/share', '/usr/lib/debug', '/usr/share', '/usr/lib/debug',
'/usr/lib/debug/hello', '/usr/bin/hello', '/usr/lib/debug/usr', '/usr/lib/debug/usr/bin',
'/usr/share/doc', '/usr/share/doc/amhello', '/usr/lib/debug/usr/bin/hello',
'/usr/bin/hello', '/usr/share/doc',
'/usr/share/doc/amhello',
'/usr/share/doc/amhello/README']) '/usr/share/doc/amhello/README'])
......
tests/integration/cmake.py
View file @ b567666d
...@@ -27,7 +27,9 @@ def test_cmake_build(cli, tmpdir, datafiles): ...@@ -27,7 +27,9 @@ def test_cmake_build(cli, tmpdir, datafiles):
assert result.exit_code == 0 assert result.exit_code == 0
assert_contains(checkout, ['/usr', '/usr/bin', '/usr/bin/hello', assert_contains(checkout, ['/usr', '/usr/bin', '/usr/bin/hello',
'/usr/lib/debug', '/usr/lib/debug/hello']) '/usr/lib/debug', '/usr/lib/debug/usr',
'/usr/lib/debug/usr/bin',
'/usr/lib/debug/usr/bin/hello'])
@pytest.mark.datafiles(DATA_DIR) @pytest.mark.datafiles(DATA_DIR)
......
tests/integration/compose.py
View file @ b567666d
...@@ -39,7 +39,8 @@ def create_compose_element(name, path, config={}): ...@@ -39,7 +39,8 @@ def create_compose_element(name, path, config={}):
# Test flat inclusion # Test flat inclusion
([], [], ['/usr', '/usr/lib', '/usr/bin', ([], [], ['/usr', '/usr/lib', '/usr/bin',
'/usr/share', '/usr/lib/debug', '/usr/share', '/usr/lib/debug',
'/usr/lib/debug/hello', '/usr/bin/hello', '/usr/lib/debug/usr', '/usr/lib/debug/usr/bin',
'/usr/lib/debug/usr/bin/hello', '/usr/bin/hello',
'/usr/share/doc', '/usr/share/doc/amhello', '/usr/share/doc', '/usr/share/doc/amhello',
'/usr/share/doc/amhello/README', '/usr/share/doc/amhello/README',
'/tests', '/tests/test']), '/tests', '/tests/test']),
...@@ -53,13 +54,17 @@ def create_compose_element(name, path, config={}): ...@@ -53,13 +54,17 @@ def create_compose_element(name, path, config={}):
'/usr/share/doc/amhello/README']), '/usr/share/doc/amhello/README']),
# Test with only runtime excluded # Test with only runtime excluded
([], ['runtime'], ['/usr', '/usr/lib', '/usr/share', ([], ['runtime'], ['/usr', '/usr/lib', '/usr/share',
'/usr/lib/debug', '/usr/lib/debug/hello', '/usr/lib/debug', '/usr/lib/debug/usr',
'/usr/lib/debug/usr/bin',
'/usr/lib/debug/usr/bin/hello',
'/usr/share/doc', '/usr/share/doc/amhello', '/usr/share/doc', '/usr/share/doc/amhello',
'/usr/share/doc/amhello/README', '/usr/share/doc/amhello/README',
'/tests', '/tests/test']), '/tests', '/tests/test']),
# Test with runtime and doc excluded # Test with runtime and doc excluded
([], ['runtime', 'doc'], ['/usr', '/usr/lib', '/usr/share', ([], ['runtime', 'doc'], ['/usr', '/usr/lib', '/usr/share',
'/usr/lib/debug', '/usr/lib/debug/hello', '/usr/lib/debug', '/usr/lib/debug/usr',
'/usr/lib/debug/usr/bin',
'/usr/lib/debug/usr/bin/hello',
'/tests', '/tests/test']), '/tests', '/tests/test']),
# Test with runtime simultaneously in- and excluded # Test with runtime simultaneously in- and excluded
(['runtime'], ['runtime'], ['/usr', '/usr/lib', '/usr/share']), (['runtime'], ['runtime'], ['/usr', '/usr/lib', '/usr/share']),
...@@ -72,7 +77,8 @@ def create_compose_element(name, path, config={}): ...@@ -72,7 +77,8 @@ def create_compose_element(name, path, config={}):
# Test excluding a custom 'test' domain # Test excluding a custom 'test' domain
([], ['test'], ['/usr', '/usr/lib', '/usr/bin', ([], ['test'], ['/usr', '/usr/lib', '/usr/bin',
'/usr/share', '/usr/lib/debug', '/usr/share', '/usr/lib/debug',
'/usr/lib/debug/hello', '/usr/bin/hello', '/usr/lib/debug/usr', '/usr/lib/debug/usr/bin',
'/usr/lib/debug/usr/bin/hello', '/usr/bin/hello',
'/usr/share/doc', '/usr/share/doc/amhello', '/usr/share/doc', '/usr/share/doc/amhello',
'/usr/share/doc/amhello/README']) '/usr/share/doc/amhello/README'])
]) ])
......