Skip to content
Snippets Groups Projects
Commit 9012a5ed authored by Tristan Van Berkom's avatar Tristan Van Berkom
Browse files

element.py: Fix _update_state() to consider whether an element is to be built properly

This was previously using self._buildable() to determine whether
an element is built locally and not to be downloaded, which misses
out on elements which have already been built, like open workspaces
which can only have their cache key calculated after the build.

This fixes issue #316
parent 71f07656
No related branches found
No related tags found
1 merge request!358Fix workspace build assertions
......@@ -1738,8 +1738,8 @@ class Element(Plugin):
metadir = os.path.join(self.__extract(), 'meta')
meta = _yaml.load(os.path.join(metadir, 'artifact.yaml'))
self.__cache_key = meta['keys']['strong']
elif self._buildable():
# Artifact will be built, not downloaded
elif self.__assemble_scheduled or self.__assemble_done:
# Artifact will or has been built, not downloaded
dependencies = [
e._get_cache_key() for e in self.dependencies(Scope.BUILD)
]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment