_sandboxremote.py: Remove unnecessary tests.

Description

Fixes #786 (closed).

The calls to verify_digest_pushed in SandboxRemote's methods run_remote_command and run do not do anything useful. push_message and push_directory will both raise assertion failures if they fail to send the digest to the server. Checking the digest returned by each only tests that the content was hashed locally, which cannot reasonably fail.

Changes proposed in this merge request:

• Remove calls to verify_digest_pushed in SandboxRemote

This merge request, when approved, will close: #786 (closed)

---

The explanation is clear, the change makes sense, I think this is

added 13 commits

• 8982988a...9a458402 - 12 commits from branch master
• 47b7a9ba - _sandboxremote.py: Remove unnecessary tests.

Compare with previous version

enabled an automatic merge when the pipeline for 47b7a9ba succeeds

This code change looks good to me.

One thing while you're touching this part of the code. The documentation comments for push_directory and push_message suggests that they will only throw CASErrors. The code here suggests they can also throw grpc.RpcError. I'm not familiar with the CASCashe code so I'm finding it difficult to work out which is correct. Perhaps as part of this MR you could ensure those comments are correct? It's a little thing which isn't worth an issue but would be helpful :)

canceled the automatic merge

@phildawson I will look into that, but it's not in scope of this MR/issue.

merged

mentioned in commit 4a8d0565