Skip to content

Move _sentinel from utils.py to _yaml.py

Daniel Silverstonerequested to merge
danielsilverstone-ct/yaml-sentinel-rework into master

Description

The utils.py::_sentinel is only used for YAML node tracking. As such, it makes more sense for the sentinel to be defined in the _yaml.py module. By doing this, we remove a need to circumvent circular imports by means of a runtime import in _yaml.py which in turn knocks tens of seconds off the startup time of bst build on projects with large numbers of elements. (25,000 in my test)

I have checked bst-external and nothing there uses _sentinel so this ought to be a safe change.

Changes proposed in this merge request:

  • Move _sentinel to _yaml.py

This merge request, when approved, will improve matters for: #466 (closed)

Merge request reports