Skip to content

element.py: Refactor overlap warnings.

Tristan Van Berkom requested to merge tristan/overlap-whitelist-no-search into master

  • Stop using Element.search() in order to match elements in the build graph when collecting overlap warnings, which is error prone and will produce incorrect results when encountering elements with the same name across project boundaries.

    Use Plugin._unique_id to match up elements instead.

  • Print Element._get_full_name() in the warning outputs, which is more accurate than element.name.

  • General refactor of code to use more descriptive variable names, improved comments, making the whole overlap code a bit more easy to understand.

Consequently, this patch also proxies _unique_id through PluginProxy as this is required by the overlap whitelist algorithm.

This fixes #1340 (closed)

Merge request reports