Skip to content

scriptelement.py: Simplify staging in the case no layout is provided

Tristan Van Berkom requested to merge tristan/scriptelement-simplify into master

The ScriptElement base class was doing a weird loop over direct build dependencies and then individual loops over their runtime dependencies when staging dependencies.

This:

  • Provided an extra message in the UI when running integration commands for each directly declared dependency, which is useless
  • Had a bad side effect of screwing with staging order when integrating
    • Every common dependency of direct dependencies would be integrated multiple times (which is often costly)
    • The order in which integration commands are applied is unclear because of the redundant staging (some dependencies later in the staging order could have an expectation of being triggered after their dependencies, this redundant staging could easily break that expectation).

Merge request reports