Remove a not very important message from the cli

The cli currently does:

        click.echo(
             "Removed '{}', therefore you can no longer run BuildStream "
             "commands from the current directory.".format(element_name),
             err=True,
         ) 

At the end of bst workspace close in the case that the command was issued while CWD was in a workspace that was consequently closed.

This is not even entirely true (it doesn't check CWD or whether bst -C was used), and is not very helpful (the user will find out anyway the next time they try to type a bst command in the removed workspace directory), it does on the other hand come with some extra, redundant and confusing core API which we can thankfully remove.

@cs-shadow, @BenjaminSchubert, @juergbi: Thoughts on this tiny refactor ?

Can we please remove this cruft ?

added 5 commits

• f72aa203 - tests/frontend/workspace.py: Removing tests
• 618173c6 - _frontent/cli.py: Removed message to user informing the workspace is closed.
• d5121cc1 - _stream.py: Remove workspace_is_required()
• b29172e0 - _project.py: Remove invoked_from_workspace_element()
• 2eccea85 - _project.py: Reorganize methods

Compare with previous version

approved this merge request

I think this is great bit of cleanup. Thanks!

I like this from a UX persepctive as well. It is our default behavior to open workspaces in the current directory. And, that is quite likley to be somewhere inside the project.

merged

mentioned in commit eec0ce41