Skip to content

element.py: Explicitly ensure failed build sources are not pushed

Tom Pollard requested to merge tpollard/failedsource into master

Description

By ordering the source push queue after the build queue, it's assumed that we don't want to push the sources from a failed build. However, this is not an explicit condition and is a by-product of queue ordering. If the intended behaviour is to not pushthe source of failed elements, we should explicitly skip as such. This does however raise questions if there was to be a bst source push command, and the wider question of a build pipeline not pushing any sources due to an irrelevant build failure in the current implementation.

Changes proposed in this merge request:

  • Explicitly skip the pushing of a source where the build result for the element is failure

Edited by Tom Pollard

Merge request reports