SandboxREAPI fixes (!1736) · Merge requests · BuildStream / buildstream · GitLab

Snippets Groups Projects

This is an archived project. Repository and other project resources are read-only.

Merged Jürg Billeter requested to merge juerg/sandbox-reapi into master 5 years ago

All threads resolved!

This branch fixes issues in SandboxREAPI discovered while testing the upcoming buildbox-run sandboxing backend (#1177 (closed)). However, they apply to remote execution as well.

Edited 5 years ago by Jürg Billeter

Activity

Darius Makovsky @traveltissues started a thread on commit 7b9b6d49 5 years ago

Resolved 5 years ago by Jürg Billeter
Last reply by Jürg Billeter 5 years ago

Jürg Billeter changed the description 5 years ago

changed the description

Jürg Billeter resolved all threads 5 years ago

resolved all threads

Darius Makovsky approved this merge request 5 years ago

approved this merge request

Jürg Billeter added 12 commits 5 years ago

added 12 commits

b78cb3c7...5c54a559 - 8 commits from branch master
af288087 - sandbox.py: Assert that the working directory is an absolute path
77487030 - _sandboxreapi.py: Fix Command.working_directory
718d872c - _sandboxreapi.py: Check that command exists
6f0c1409 - _sandboxreapi.py: Ensure /dev, /proc and /tmp exist in sandbox

Compare with previous version

Toggle commit list

Jürg Billeter added 4 commits 5 years ago

added 4 commits

3a03fe66 - sandbox.py: Assert that the working directory is an absolute path
5dedeb8d - _sandboxreapi.py: Fix Command.working_directory
364a3164 - _sandboxreapi.py: Check that command exists
ba2aba84 - _sandboxreapi.py: Ensure /dev, /proc and /tmp exist in sandbox

Compare with previous version

Toggle commit list

Jürg Billeter merged 5 years ago

merged

Jürg Billeter mentioned in commit 5 years ago

mentioned in commit 85a29b48

Please register or sign in to reply