Skip to content

Improve assertions around element loading progress reporting

Tristan Maat requested to merge tlater/progress-tests into master

Description

We should be safe now - the XXX in particular turned out to be involved in loading dependencies of junction elements, rather than anything in their projects.

This meant that, yes, we were missing progress, however junction elements are not allowed to have dependencies in the first place, so we simply short-circuit their load and avoid the problem altogether.

Other than that, this adds a more explicit way of specifying that we don't want to report progress, which should hopefully help raise confidence and make #1094 (closed) closable.

Changes proposed in this merge request:

  • A handful of new tests
  • Early return for loading of junction elements' dependencies
    • Junction elements are not allowed to have dependencies, so this just means we need to load less
  • More robust assertions to ensure progress reporting is only skipped deliberately

This merge request, when approved, will close: #1094 (closed)

Edited by Tristan Maat

Merge request reports