Skip to content

Don't directly handle Elements and Queues in App

Tom Pollard requested to merge tpollard/frontendelement into master

Description

When there is process separation between the frontend & backend process, any activity in app.py that happens mid process (i.e a failed build job) should not require objects such as Elements & Queues to be pickled just for the sake of user interaction. This MR aims to handle Element/Object direct handling that is determined via App to be done with Stream, which will make the transition to further split work (bidirectional notification queue) more digestible. Part of #1036 (closed)

Changes proposed in this merge request:

  • Don't require the actual Element instance just for creating a shell display prompt
  • Pass the Element's unique_id & display keys as a tuple instead of the whole object when handling failure, the unique_id will eventually be needed to load the correct element related to the given process plugin state.
  • Don't change queue state when retrying a failure within app, delegate this to Stream
Edited by Tom Pollard

Merge request reports