enable PyLint "arguments-differ" error, and fixup complaints

Angelos Evripiotisrequested to merge
aevri/pylint_argsdiff into master

Summary:

Enable PyLint "arguments-differ" error, and fixup complaints.

By making the signatures of overridden methods deliberately match, we can use PyLint to ensure the signatures don't accidentally differ.

  • pylint: enable arguments-differ
  • _frontend/widget: match LogFile.render to base cls
  • _gitsourcebase: ignore or fix arguments-differ err
  • _fuse: converge args for link() and symlink()
  • _fuse/fuse: make create() match SafeHardlinkOps
  • _fuse: match SafeHardlinkOps to base class
  • _casbaseddirectory: match methods to base class
  • _filebaseddirectory: match methods to base class
  • CliIntegration: match methods to base class
  • testing/_utils: match git methods to base class
  • _options: match methods to base class

Detail:

While authoring !1373 (merged), I changed a base class method to take less parameters but forgot to update an override in a sub-class. Thankfully @raoul.hidalgocharman caught this mistake, and all was well.

I looked into our PyLint configuration and found that the disabled arguments-differ error would also have caught this.

In this MR, I'm enabling this check and fixing up anything it complains about.

By making the signatures of overridden methods deliberately match, we can use PyLint to ensure the signatures don't accidentally differ.

Edited by Angelos Evripiotis

Merge request reports