Skip to content

Reduce the amount of times we call Element._update_state()

Jonathan Maw requested to merge jonathan/reduce-update-state-calls into master

Description

These are the trivial changes to reducing the amount of times we call Element._update_state().

Changes proposed in this merge request:

  • In Element._fetch_done(), we only call Element.__update_source_state(), because the element's assorted bits, and their cache keys, cannot change as a result (strictly speaking, it would be possible if fetching wasn't already blocked when sources have not been tracked).
  • In Element._schedule_tracking(), we don't call Element._update_state() because all changes are blocked by Element.__tracking_scheduled.

This merge request is part of #902 (closed) but does not close it.

Merge request reports