Skip to content

BREAK:remove unconditional 'are you sure?' prompts

Angelos Evripiotisrequested to merge
aevri/are_you_sure into master

Description

This is a breaking change, as it affects behaviour that people might be relying on. An entry has been added to NEWS.

As proposed on the mailing list, this change removes the unconditional prompts on:

  • bst workspace reset
  • bst workspace close --remove-dir

If interactive, these commands would always interrupt you with a prompt like this:

This will remove all your changes, are you sure?

This seems like it may just save someone's work some time. It may also condition folks to hit 'y' quickly without thinking.

This change also makes the non-interactive behaviour consistent with the interactive behaviour in the default case. There is also the case of the prompt configured by 'really-workspace-close-project-inaccessible', which may be tackled in later work.

Changes proposed in this merge request

  • Remove prompt.really-workspace-close-remove-dir config and prompt.
  • Remove prompt.really-workspace-reset-hard config and prompt.
  • Add entry to NEWS about breaking changes.

Relevant links

This helps #744 (closed)

The relevant bit of the mailing list conversation is here: https://mail.gnome.org/archives/buildstream-list/2018-December/msg00106.html

Edited by Angelos Evripiotis

Merge request reports