Some tests break with pytest 5.4.1

I noticed the issue in this failed update-dependencies job.

It's fairly easy to reproduce if you have pytest installed in a virtual environment. Just update it to the latest version and try running tests/frontend/workspace.py::test_build for example.

Here's the relevant bits of the error log:

cli = <buildstream.testing.runcli.Cli object at 0x7f8b2af3ac10>
tmpdir_factory = TempdirFactory(_tmppath_factory=TempPathFactory(_given_basetemp=PosixPath('/home/kote/buildstream/buildstream/tmp'), _...pluggy._tracing.TagTracerSub object at 0
x7f8b2af3a610>, _basetemp=PosixPath('/home/kote/buildstream/buildstream/tmp')))
datafiles = local('/home/kote/buildstream/buildstream/tmp/test_build_project_no_guess_no0'), kind = 'git', strict = 'non-strict', from_workspace = False, guess_element = False

    def test_build(cli, tmpdir_factory, datafiles, kind, strict, from_workspace, guess_element):
>       tmpdir = tmpdir_factory.mktemp("")

tests/frontend/workspace.py:661:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../../.venvs/bst/lib64/python3.7/site-packages/_pytest/tmpdir.py:118: in mktemp
    return py.path.local(self._tmppath_factory.mktemp(basename, numbered).resolve())
../../.venvs/bst/lib64/python3.7/site-packages/_pytest/tmpdir.py:70: in mktemp
    basename = self._ensure_relative_to_basetemp(basename)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = TempPathFactory(_given_basetemp=PosixPath('/home/kote/buildstream/buildstream/tmp'), _trace=<pluggy._tracing.TagTracerSub object at 0x7f8b2af3a610>, _basetemp=PosixPath('/
home/kote/buildstream/buildstream/tmp'))
basename = '.'

    def _ensure_relative_to_basetemp(self, basename: str):
        basename = os.path.normpath(basename)
        if (self.getbasetemp() / basename).resolve().parent != self.getbasetemp():
            raise ValueError(
>               "{} is not a normalized and relative path".format(basename)
            )
E           ValueError: . is not a normalized and relative path

I've got a fix for this, can push tomorrow

Just to confirm, is that while running with -n?

mentioned in merge request !1879 (merged)

closed via merge request !1879 (merged)

mentioned in commit 943e2554