Remove usage of deprecated Buildstream API

Nathan Williamsrequested to merge
nathan/deprecated into master

In the Buildstream API, node_subst_vars and node_subst_sequence_vars were marked as deprecated 6 years ago (April 16th, 2020 5:56 PM) https://github.com/apache/buildstream/commit/e5ed02da0b99c16481eac58963f4ebbdf0481590

The methods became almost a no-op as configuration is now automatically expanded, the only thing it does is convert a ScalerNode or SequenceNode[ScalerNode] type to str or list[str].

So I have replaced all instances of:

  • self.node_subst_vars(node) with node.as_str()
  • self.node_subst_sequence_vars(node) with node.as_str_list()

fixes: #94 (closed)

also see: https://github.com/apache/buildstream/pull/2154

Edited by Nathan Williams

Merge request reports