Commit be1205a7 authored by Arber X's avatar Arber X 😀
Browse files

Start the implementation of the getTree method

parent 2a04f0ae
Show whitespace changes
Inline Side-by-side
  • Arber X 😀 @arberx ·
    Author Contributor

    @martinblanchard Hi Martin, my current progress is documented in this commit. If you have a chance, please provide some feedback.

  • finn @finnball ·
    Contributor

    It may be easier if you make a WIP MR so you can invite people to read your first draft :)

  • Martin Blanchard @martinblanchard ·
    Contributor

    Thanks for sharing this early @arberx! As @finnball suggested, feel free to create a WIP: merge request. Looks good so far, a few comments:

    • I would try to avoid using output parameters, they are not very popular in Python I think. A common practice is to return a tuple that the caller unpacks.
    • I would not propagate the GetTreeRequest message out of the service class and I would consider it immutable, I think that's what the other services are doing.
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment