Skip to content

Remove old create_lease() methods from data store interface

Neill Whillans requested to merge neill/remove_dead_code into master

Before raising this MR, consider whether the following are required, and complete if so:

  • Unit tests
  • Metrics
  • Documentation update(s)

If not required, please explain in brief why not.

Description

This request aims to remove the no longer used create_lease() method of buildgrid/server/persistence/interface.py, and the corresponding method in the memory based datastore implementation in buildgrid/server/persistence/mem/impl.py. The method in the database datatstore implementation was kept, as it is used in tests/test_scheduler.py, but a note was added to the method to explain the reason why.

Changes proposed in this merge request:

  • Remove dead create_lease() methods
  • Add note to explain why one create_lease() method is kept

Validation

n/a

Issues addressed

Closes / Resolves / Addresses (delete as appropriate) issue <e.g. repo-name#x>

Merge request reports