Don't use error field in operation message
Before raising this MR, consider whether the following are required, and complete if so:
-
Unit tests -
Metrics -
Documentation update(s)
If not required, please explain in brief why not.
Description
The REAPI is very explicit that the Operation's error field must not be populated, and instead a proper Status message must be set in the ExecuteResponse
. This PR updates BuildGrid to do just that.
As part of adding tests I also found a small bug where operations associated with a job after it's cancellation aren't themselves marked as cancelled in some cases. This was causing some tests in test_scheduler.py
to fail in a flaky way, so I've added a small commit to address that as well.
Changes proposed in this merge request:
- Stop populating the Operation's error field and instead construct an ExecuteResponse message with the relevant status set.
Issues addressed
Closes #398 (closed)
Edited by Jeremiah Bonney