Skip to content

Only update timestamps on FMB, not other read operations

Jeremiah Bonney requested to merge jbonney/remove-timestamp-updates-reads into master

Before raising this MR, consider whether the following are required, and complete if so:

  • Unit tests
  • Metrics
  • Documentation update(s)

If not required, please explain in brief why not.

Description

When re-reading the REAPI spec I realized that the only place which mentions refreshing the lifetime of blobs in CAS is for FindMissingBlobs requests: https://github.com/bazelbuild/remote-apis/blob/main/build/bazel/remote/execution/v2/remote_execution.proto#LL339

In BuildGrid for IndexedCAS we update the accessed_timestamp on all read operations, which makes these operations more expensive than they need to be (although the addition of refresh_accesstime_older_than does make this cheaper than it once was). This PR removes the updating of timestamps for all the read requests outside of FindMissingBlobs, which reduces the number of queries needed for these operations.

Merge request reports