Skip to content

Remove max_get_timeout and instead use MAX_WORKER_TTL for default

Jeremiah Bonney requested to merge jbonney4/remove-max-get-timeout into master

Before raising this MR, consider whether the following are required, and complete if so:

  • Unit tests
  • Metrics
  • Documentation update(s)

If not required, please explain in brief why not.

Description

This PR removes the usage of max_get_timeout, which was already partially removed in !869 (merged) when refactoring how SQL connections are managed. This previously was used to assign different defaults for how long to have workers long-poll for work when no deadline is specified for the in-memory and sql schedulers, but as of now it's always 0.

Instead of adding it back, I think it makes more sense to just remove it all together and instead default to MAX_WORKER_TTL instead. If the client doesn't set a deadline it makes sense to default to a larger one instead of a smaller one, especially now that we handle job assignments and long-polling much more efficiently.

Changes proposed in this merge request:

  • Default to using MAX_WORKER_TTL if no deadline is specified when bots ask for work
  • Remove max_get_timeout as it's no longer needed

Validation

Bring up BuildGrid and buildbox-worker with no --request-timeout or --bots-request-timeout set and verify it long-polls instead of asking for work every few seconds.

Issues addressed

Closes / Resolves / Addresses (delete as appropriate) issue <e.g. repo-name#x>

Merge request reports