Skip to content

Fix flaky test_watcher_detects_changes by allowing a more flexible timeout

Zehao Chen requested to merge zchen723/fix-watcher-test into master

Before raising this MR, consider whether the following are required, and complete if so:

  • Unit tests
  • Metrics
  • Documentation update(s)

Description

This MR adds a utility function poll_and_assert to fix the flaky test test_watcher_detects_changes that has been blocking the CI.

For test cases that have the "sleep-then-assert" pattern, they can be flaky given CIs are running on shared Gitlab runners which are often loaded. Polling with a shorter interval and longer timeout might help.

Edited by Zehao Chen

Merge request reports