Skip to content

Add a metric to record cache hits which have missing blobs

Adam Coldrick requested to merge sotk/action-cache/hit-with-missing-blobs-metric into master

Before raising this MR, consider whether the following are required, and complete if so:

  • Unit tests
  • Metrics
  • Documentation update(s)

If not required, please explain in brief why not.

Description

A cache hit with blobs from the ActionResult missing from the CAS is returned as a cache miss. Hitting this situation could be an indication of CAS cleanup being too aggressive if it occurs regularly, so it is useful to monitor.

This commit also updates the docker-compose example with monitoring to have the ActionCache publish metrics, allowing this metric to be seen.

Validation

Using the docker-compose example with monitoring enabled, upload an ActionResult with missing blobs and then request it, as described in !824 (merged). Then go to add a panel in grafana (http://localhost:3000, credentials admin/admin) and the metric should be visible.

docker-compose -f docker-compose.cache-monitoring.yml up --build

Merge request reports