Skip to content

Adds Shutdown Logging for Cleanup Service

Joel DeLong requested to merge jdelong12/buildgrid:jdelong12/logging into master

Before raising this MR, consider whether the following are required, and complete if so:

  • Unit tests
  • Metrics
  • Documentation update(s)

If not required, please explain in brief why not.

These are not required because this PR adds logging to increase debugging ease, which does not require unit tests, documentation, or metrics.

Description

While testing a buildgrid configuration, the cleanup daemon exited zero causing another service to fail. Debug was difficult because there was no log message to indicate what was happening. This change adds logging when the cleanup daemon stops.

Changes proposed in this merge request:

  • logging added in cleanup.py

Validation

Open two terminals. run the command

docker-compose -f docker-compose-monitoring.yml up

in one terminal, and from the other terminal run

docker-compose down

and watch the logs of the first terminal. "Stopping Cleanup Service" will appear in the logs when the service shuts down.

Edited by Joel DeLong

Merge request reports