Skip to content

Draft: test_pika_helpers.py: Make all pika imports conditional (fixes `unit-tests-multiple-interpreters` CI job)

Santiago Gil requested to merge santigl/rabbitmq/pika-tests-conditional-includes into master

Before raising this MR, consider whether the following are required, and complete if so:

  • [ ] Unit tests
  • [ ] Metrics
  • [ ] Documentation update(s)

If not required, please explain in brief why not.

Description

The changes in !692 (merged) made the unit-tests-multiple-interpreters CI job fail due to pika being missing.

Changes proposed in this merge request:

  • tests/rabbitmq/test_pika_helpers.py: skip all imports that require pika to avoid errors if not present

Validation

See output from this branch, which forces unit-tests-multiple-interpreters to run with these changes: https://gitlab.com/BuildGrid/buildgrid/-/jobs/1427045554 (otherwise the job is only executed for master).

Edited by Santiago Gil

Merge request reports