Skip to content

server/cas/service.py: do not log contents of blobs

Santiago Gil requested to merge santigl/cas-do-not-log-data into master

Before raising this MR, consider whether the following are required, and complete if so:

  • [ ] Unit tests
  • [ ] Metrics
  • [ ] Documentation update(s)

If not required, please explain in brief why not.

Description

As described in #369 (closed), when catching an exception, the CAS servicers log the whole request message, including the contents of blobs in the case of BatchUpdateBlobs() and ByteStream.Write().

This removes the contents of the blobs from those log messages.

Changes proposed in this merge request:

  • ContentAddressableStorageService.BatchUpdateBlobs(), ByteStreamService.Write(): cherry-pick the relevant fields from the request message for logging instead of using the request's own formatter

Issues addressed

Closes #369 (closed)

Merge request reports