Skip to content

Represent operations with their instance names everywhere

Rohit Kothur requested to merge rkothur/instance-prefixed-everywhere into master

Before raising this MR, consider whether the following are required, and complete if so:

  • Unit tests
  • Metrics
  • Documentation update(s)

Just need to update the existing tests.

Description

Represent operations with their instance names everywhere. An instance name prefix is required for GetOperation since there is no separate instance_name field, but BuildGrid currently represents it in the data store without this prefix. Therefore, it needs to do a lot of unnecessary prefixing and unprefixing whenever an RPC is called.

Note that jobs submitted to the empty instance name will still have the prefixing slash, i.e. they'll look like "/6daf77d3-9c0a-4fcf-b2ef-265df30150fe".

Changes proposed in this merge request:

  • Remove prefixing and unprefixing from the Execution and Operations services
  • Update relevant tests

Note

This is a breaking change. If an Action was submitted asynchronously to a deployed BuildGrid, and that BuildGrid then receives this change, the operation name returned from the submission can no longer be used to retrieve the status of that Action.

Issues addressed

Closes #346 (closed)

Edited by Rohit Kothur

Merge request reports