Skip to content

When retrying leases bots are not reporting, unassign them from botsession

Marios Hadjimichael requested to merge marios/unassign-missing-bot-leases-on-retry into master

Before raising this MR, consider whether the following are required, and complete if so:

  • Unit tests - Added a test
  • Metrics - N/A
  • Documentation update(s) - N/A

Description

While we make sure to retry leases that bots may have dropped, we never update the in-memory botsession assignments we keep, thus we keep retrying this with each botsession once this happens. The main problem with that is that we keep logging the same thing with each UpdateBotSession request once a job was completed by another bot.

This MR un-assigns the lease from this botsession (new addition), after telling the scheduler to retry it (existing behavior).

Merge request reports